gitops-operator
gitops-operator copied to clipboard
fix(Makefile): Remove duplicate operator-sdk goal, simplify code
What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
The goal was duplicate with similar (but not same) logic - eliminated.
The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now. Element of least astonishment.
Conditional Makefile logic removed leveraging native make features.
Have you updated the necessary documentation?
- [n/a] Documentation update is required by this PR.
- [n/a] Documentation has been updated.
Which issue(s) this PR fixes:
None
Test acceptance criteria:
- [n/a] Unit Test
- [n/a] E2E Test
How to test changes / Special notes to the reviewer:
make bundlerm -rf ./bin && make bundlemake OPERATOR_SDK=/bin/operator-sdk bundle# When installed locally
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @olivergondza. Thanks for your PR.
I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
/retest
The tests are passing, this is ready for review.
Any comments, objections?
@olivergondza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/v4.14-e2e | 7554ca66e617fcd4720b564397191d9e91cdb905 | link | true | /test v4.14-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.