gitops-operator icon indicating copy to clipboard operation
gitops-operator copied to clipboard

Adding minikube version compatability code

Open sarfarazgit opened this issue 9 months ago • 5 comments

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • [ ] Documentation update is required by this PR.
  • [ ] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • [ ] Unit Test
  • [ ] E2E Test

How to test changes / Special notes to the reviewer:

sarfarazgit avatar Feb 10 '25 10:02 sarfarazgit

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sbose78 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 10 '25 10:02 openshift-ci[bot]

Hi @sarfarazgit. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Feb 10 '25 10:02 openshift-ci[bot]

/ok-to-test

iam-veeramalla avatar Feb 11 '25 05:02 iam-veeramalla

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Feb 18 '25 15:02 openshift-merge-robot

@sarfarazgit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.17-e2e b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.17-e2e
ci/prow/v4.17-kuttl-parallel b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.17-kuttl-parallel
ci/prow/v4.17-kuttl-sequential b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.17-kuttl-sequential
ci/prow/v4.14-kuttl-sequential b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.14-kuttl-sequential
ci/prow/v4.19-kuttl-parallel b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.19-kuttl-parallel
ci/prow/v4.19-ci-index-gitops-operator-bundle b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.19-ci-index-gitops-operator-bundle
ci/prow/v4.19-e2e b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.19-e2e
ci/prow/v4.19-images b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.19-images
ci/prow/v4.19-kuttl-sequential b853e96f7621eeb4a532776f1fc40517238562d1 link true /test v4.19-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 16 '25 14:09 openshift-ci[bot]