gitops-operator icon indicating copy to clipboard operation
gitops-operator copied to clipboard

Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available (cherry-pick)

Open anandf opened this issue 1 year ago • 5 comments

What type of PR is this? /kind bug

What does this PR do / why we need it: Upgraded ArgoCD Operator and ArgoCD to pick up the fix related to ArgoCD UI broken when the route API becomes unavailable momentarily.

When there is an issue with the API server pods, or the API server pods are just coming up after a restart, the current check for API availability done with a discovery client will fail. This makes the operator code to assume that the server does not support the Route API. To fix this, whenever the API availability check fails, the operator checks if the API is registered. If registered, then the operator assumes that the Route API is supported in the cluster and would eventually become available.

Have you updated the necessary documentation?

  • [ ] Documentation update is required by this PR.
  • [ ] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-4358

Test acceptance criteria:

  • [ ] Unit Test
  • [ ] E2E Test

How to test changes / Special notes to the reviewer:

anandf avatar Aug 26 '24 13:08 anandf

/retest

anandf avatar Sep 16 '24 13:09 anandf

/approve

anandf avatar Sep 16 '24 13:09 anandf

@anandf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gitops-ocp4.14-lp-interop-images 6d1478256a939a1fda68eb3493b8f97ef5cfa3d2 link true /test gitops-ocp4.14-lp-interop-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 16 '24 16:09 openshift-ci[bot]

/lgtm /approve

svghadi avatar Oct 02 '24 13:10 svghadi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf, svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 02 '24 13:10 openshift-ci[bot]