gitops-operator icon indicating copy to clipboard operation
gitops-operator copied to clipboard

Add dashboard for Rollouts

Open gnunn1 opened this issue 1 year ago • 2 comments

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring

What does this PR do / why we need it:

This PR adds a new dashboard to the OpenShift Console for Rollouts. It leverages the metrics provided by the operator deployed servicemonitor for Rollouts. This dashboard is based on the upstream Argo Rollouts dashboard but tuned and tweaked for the Console.

Have you updated the necessary documentation?

  • [ *] Documentation update is required by this PR.
  • [ ] Documentation has been updated.

Which issue(s) this PR fixes:

No issue has been opened for this but can open one if needed.

Test acceptance criteria:

  • [*] Unit Test
  • [ ] E2E Test

This is covered by the existing dashboards unit tests.

How to test changes / Special notes to the reviewer:

Run the operator and validate that a Rollouts Dashboard appears in the OpenShift console. Assuming Rollouts are deployed on the various graphs will populate with metrics.

gnunn1 avatar Aug 02 '24 16:08 gnunn1

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rnapoles-rh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 02 '24 16:08 openshift-ci[bot]

Hi @gnunn1. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 02 '24 16:08 openshift-ci[bot]

/ok-to-test

jgwest avatar Aug 07 '24 08:08 jgwest

@gnunn1 Sent you an invite to allow you to skip /ok-to-test requirement.

jgwest avatar Aug 07 '24 08:08 jgwest

/retest

gnunn1 avatar Aug 08 '24 17:08 gnunn1

/retest

Failed on: --- FAIL: kuttl/harness/1-074_validate_terminating_namespace_block (27.84s) --- FAIL: kuttl/harness/1-057_validate_notifications (105.24s)

jgwest avatar Aug 09 '24 07:08 jgwest

/approved /lgtm

jgwest avatar Aug 09 '24 09:08 jgwest