gitops-operator
gitops-operator copied to clipboard
Add dashboard for Rollouts
What type of PR is this?
Uncomment only one
/kindline, and delete the rest. For example,> /kind bugwould simply become:/kind bug
/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring
What does this PR do / why we need it:
This PR adds a new dashboard to the OpenShift Console for Rollouts. It leverages the metrics provided by the operator deployed servicemonitor for Rollouts. This dashboard is based on the upstream Argo Rollouts dashboard but tuned and tweaked for the Console.
Have you updated the necessary documentation?
- [ *] Documentation update is required by this PR.
- [ ] Documentation has been updated.
Which issue(s) this PR fixes:
No issue has been opened for this but can open one if needed.
Test acceptance criteria:
- [*] Unit Test
- [ ] E2E Test
This is covered by the existing dashboards unit tests.
How to test changes / Special notes to the reviewer:
Run the operator and validate that a Rollouts Dashboard appears in the OpenShift console. Assuming Rollouts are deployed on the various graphs will populate with metrics.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rnapoles-rh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @gnunn1. Thanks for your PR.
I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
@gnunn1 Sent you an invite to allow you to skip /ok-to-test requirement.
/retest
/retest
Failed on: --- FAIL: kuttl/harness/1-074_validate_terminating_namespace_block (27.84s) --- FAIL: kuttl/harness/1-057_validate_notifications (105.24s)
/approved /lgtm