gitops-operator
gitops-operator copied to clipboard
redhat-developer
GITOPS-477 Add back non-kuttl test execution.
What type of PR is this? /kind code-refactoring
What does this PR do / why we need it: Non-kuttl test execution was removed in a previous PR as the 'printer' package is no longer available in "sigs.k8s.io/controller-runtime/pkg/envtest/printer"
Which issue(s) this PR fixes:
Fixes #? GITOPS-4777
How to test changes / Special notes to the reviewer:
make test-e2e should now execute (without RunSpecsWithDefaultAndCustomReporters)
@trdoyle81: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.
In response to this:
What type of PR is this? /kind code-refactoring
What does this PR do / why we need it: Non-kuttl test execution was removed in a previous PR as the 'printer' package is no longer available in "sigs.k8s.io/controller-runtime/pkg/envtest/printer"
Which issue(s) this PR fixes:
Fixes #? GITOPS-4777
How to test changes / Special notes to the reviewer:
make test-e2eshould now execute (without RunSpecsWithDefaultAndCustomReporters)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Cleared a few records
level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "ocp-gitops-qe.com": the zone already has record sets for the domain of the cluster: [api.ci-op-sj8g5wyn-16175.ocp-gitops-qe.com. (A), \052.apps.ci-op-sj8g5wyn-16175.ocp-gitops-qe.com. (A)]
Installer exit with code 1
/retest
@trdoyle81 ci/prow/v4.13-e2e and ci/prow/v4.14-e2e have some test failure.
/test v4.12-e2e
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign svghadi for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I see the non default e2e tests suite is failing with
go test -p 1 -timeout 1h ./test/e2e -coverprofile cover.out -ginkgo.v
ok github.com/redhat-developer/gitops-operator/test/e2e 581.156s coverage: [no statements]
go test -p 1 -timeout 1h ./test/nondefaulte2e -coverprofile cover.out -ginkgo.v
....
2024-07-25T11:52:55Z ERROR controller-runtime.source.EventHandler kind must be registered to the Scheme {"error": "no kind is registered for the type v1alpha1.NotificationsConfiguration in scheme \"k8s.io/client-go/kubernetes/scheme/register.go:80\""}
We probably need the same import fix as the one made in test/e2e/suite_test.go. - @trdoyle81
here: https://github.com/redhat-developer/gitops-operator/blob/13cd6610a63028659c7e7a64447ef2ccd85c92ee/test/nondefaulte2e/suite_test.go#L97
@trdoyle81: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/unit | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test unit |
| ci/prow/v4.12-e2e | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.12-e2e |
| ci/prow/v4.12-ci-index-gitops-operator-bundle | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.12-ci-index-gitops-operator-bundle |
| ci/prow/v4.12-images | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.12-images |
| ci/prow/v4.13-ci-index-gitops-operator-bundle | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.13-ci-index-gitops-operator-bundle |
| ci/prow/v4.12-kuttl-sequential | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.12-kuttl-sequential |
| ci/prow/v4.12-kuttl-parallel | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.12-kuttl-parallel |
| ci/prow/v4.13-e2e | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.13-e2e |
| ci/prow/v4.13-images | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.13-images |
| ci/prow/v4.13-kuttl-parallel | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.13-kuttl-parallel |
| ci/prow/v4.13-kuttl-sequential | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.13-kuttl-sequential |
| ci/prow/v4.14-ci-index-gitops-operator-bundle | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.14-ci-index-gitops-operator-bundle |
| ci/prow/v4.14-e2e | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.14-e2e |
| ci/prow/v4.14-kuttl-parallel | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.14-kuttl-parallel |
| ci/prow/v4.14-images | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.14-images |
| ci/prow/v4.14-kuttl-sequential | 744f0c535fdeb6512aa9c7e8bc8e162c1e11fdd7 | link | true | /test v4.14-kuttl-sequential |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.