gitops-operator
gitops-operator copied to clipboard
clearer instruction to disable default argocd instance
What type of PR is this? /kind documentation
What does this PR do / why we need it:
Specifically mentioning to edit the env resource within the subscriptions.operators.coreos.com.spec.config CRD to add the associated env. var. in order to disable the default argocd instance launch.
Have you updated the necessary documentation?
- [ ] Documentation update is required by this PR.
- [x] Documentation has been updated.
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
- [ ] Unit Test
- [ ] E2E Test
How to test changes / Special notes to the reviewer:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jopit for approval by writing /assign @jopit in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @makeittotop. Thanks for your PR.
I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
ok-to-test
/retest
@makeittotop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/v4.8-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.8-kuttl-sequential |
| ci/prow/v4.8-kuttl-parallel | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.8-kuttl-parallel |
| ci/prow/v4.9-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.9-kuttl-sequential |
| ci/prow/v4.12-kuttl-parallel | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.12-kuttl-parallel |
| ci/prow/v4.12-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.12-kuttl-sequential |
| ci/prow/v4.10-kuttl-parallel | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.10-kuttl-parallel |
| ci/prow/v4.10-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.10-kuttl-sequential |
| ci/prow/v4.11-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.11-kuttl-sequential |
| ci/prow/v4.13-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.13-kuttl-sequential |
| ci/prow/v4.13-kuttl-parallel | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.13-kuttl-parallel |
| ci/prow/v4.13-e2e | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.13-e2e |
| ci/prow/v4.14-kuttl-sequential-periodic | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.14-kuttl-sequential-periodic |
| ci/prow/v4.14-kuttl-sequential | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.14-kuttl-sequential |
| ci/prow/v4.14-kuttl-parallel | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.14-kuttl-parallel |
| ci/prow/v4.14-e2e | ebfc639c4e0599dce875a4cef4f7ef92c8bebd94 | link | true | /test v4.14-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@makeittotop I know it is an old PR but can you rebase this ?
Sure, doing it
On Wed, Sep 4, 2024 at 10:49 AM Saumeya Katyal @.***> wrote:
@makeittotop https://github.com/makeittotop I know it is an old PR but can you rebase this ?
— Reply to this email directly, view it on GitHub https://github.com/redhat-developer/gitops-operator/pull/412#issuecomment-2329652121, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFYC7JEN7R53GHOBSCPNWDZU5BY5AVCNFSM6AAAAABNU2NLOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGY2TEMJSGE . You are receiving this because you were mentioned.Message ID: @.***>