cglm icon indicating copy to clipboard operation
cglm copied to clipboard

aabb2d Struct API missing diag and sizev functions from Array API

Open rogeriodomingos opened this issue 1 year ago • 3 comments

The aabb2d Struct API has glms_aabb2d_size which should probably be renamed to glms_aabb2d_diag and call glm_aabb2d_diag from the Array API. It is also missing glms_aabb2d_sizev which should call glm_aabb2d_sizev.

rogeriodomingos avatar Sep 03 '24 14:09 rogeriodomingos

Hi @rogeriodomingos,

Thanks for the catch! I’ll do it asap if no one intends to create a PR :)

recp avatar Sep 05 '24 14:09 recp

I might pick this one up this weekend, it's my fault anyway

duarm avatar Sep 20 '24 23:09 duarm

Hi @duarm,

Sounds great, thanks! 👍

recp avatar Sep 22 '24 14:09 recp