recogito-js icon indicating copy to clipboard operation
recogito-js copied to clipboard

Highlighting collapses completely

Open kdaniel21 opened this issue 3 years ago • 4 comments
trafficstars

Hi!

While testing the library in the playground, we've found a bug with @st3h3n. The highlighting collapses completely if an already annotated piece of text is selected in a way that both at the beginning, and the end the text cursor is visible. First, the exception is raised, an then Recogito does not seem to be able to recover from that. Peek 2022-07-14 17-34

kdaniel21 avatar Jul 14 '22 15:07 kdaniel21

Thanks for reporting. I think I've actually seen that before, and it doesn't specifically happen for the annotations only, but for particular edge cases in the markup which (I think) involve tag boundaries and spaces or something. I never was able to thoroughly reproduce it with test documents. But it looks like you finally nailed down a reproducible way to trigger the issue. I'll look into it.

rsimon avatar Jul 14 '22 15:07 rsimon

Weird - I tried this now (FF and Chrome) and, just like issue #76, I couldn't reproduce. Can you post which RecogitoJS version you are using, and on what browser and OS you are seeing the bug?

rsimon avatar Jul 24 '22 12:07 rsimon

This is the publicly available, tested in Firefox Developer Edition version 103.0b9 (64-bit), under Kubuntu 22.04. Besides, @st3h3n used the latest (?) version of Edge under Windows 11 to reproduce it, so I'd assume that it is not specific to my machine.

As in the other GitHub issue, could you please post a GIF of you attempting to reproduce the issue? It might help us nail down where exactly your way of reproducing deviates from ours.

kdaniel21 avatar Jul 26 '22 13:07 kdaniel21

Ah - well, no, the public demo is hopelessly outdated. You can grab the latest version off the CDN here: https://cdn.jsdelivr.net/npm/@recogito/[email protected]/dist/recogito.min.js https://cdn.jsdelivr.net/npm/@recogito/[email protected]/dist/recogito.min.css

Sorry for this! (I wish there was more time to maintain this thing... especially docs ;-)

rsimon avatar Jul 26 '22 14:07 rsimon

Similarly to #76, I couldn't reproduce this issue either in a different environment using the newest Recogito. I'll close this one as well, and we'll keep an eye on the potential bug. A big thank you from here again! ;)

kdaniel21 avatar Aug 13 '22 01:08 kdaniel21