bs-express icon indicating copy to clipboard operation
bs-express copied to clipboard

Call for New Maintainer

Open ncthbrt opened this issue 5 years ago • 9 comments

Hi there, bs-express is looking for a new maintainer. I have been quite passively triaging issues and reviewing PRs, however I am not actively involved in the ReasonML community currently and so have not been keeping up with recent developments or changes to tooling and best practices.

I am happy to continue maintaining this repo in a passive manner, however I believe the project would be better served by someone who is willing to more actively take charge of the project and make more substantive improvements to the ergonomics or design of the library.

Natalie

ncthbrt avatar Jul 05 '20 10:07 ncthbrt

@ncthbrt , I would certainly consider taking an active role on this. I'm not sure how much effort I can devote to it, but I can definitely help with some of the maintenance.

I happen to be one of the main authors/maintainers of reason-nodejs, and I have some experience with Express, so it would probably be a natural fit for me.

I'll take a look at the repo. Let me know what you think.

austindd avatar Jul 22 '20 01:07 austindd

Hi @austindd that'd be fantastic. Please do check it out.

ncthbrt avatar Jul 22 '20 06:07 ncthbrt

@ncthbrt @austindd I'd be happy to help.

make more substantive improvements to the ergonomics or design of the library.

Is there anything in particular you had in mind? I'm relatively new to the ReasonML community, but eager to start contributing in way fashion.

There are some improvements I feel could be made. For instance, Response.sendFile's second parameter is a generic type. I think it would be great if we accepted a some specific type here, and offer a make() function with optional parameters for each configurable key/value pair. That way intellisense / code completion in editors can assist developers when trying to use the sendFile method. I'm not sure if you'd agree if that would be a worthwhile change or not. If so, one concern is backwards compatibility. I'm not too sure how to handle that or what the community expectations would be.

mweichert avatar Aug 23 '20 21:08 mweichert

Response.sendFile's second parameter is a generic type. I think it would be great if we accepted a some specific type here That kind of improvement would certainly help. But I think one of the singularly most effective improvements probably would be some lightweight documentation.

ncthbrt avatar Aug 24 '20 14:08 ncthbrt

I use bs-express pretty extensively and would be happy to help out.

maxkorp avatar Sep 01 '20 01:09 maxkorp

@maxkorp Would you still be interested?

ncthbrt avatar Jan 29 '21 10:01 ncthbrt

I'd like to tune in into this discussion, since we are currently in the process of figuring out what to do with all the active / obsolete projects on the reasonml-community org (which is now a little conflicting after the ReScript rebrand).

If @maxkorp or @austindd would be interested in taking ownership of this whole thing, I'd propose to move this repository over to their personal / business gh organizations, so we can declutter the reasonml-community org from ReScript related content.

Ideally we'd move this repo to a company handle that uses the bindings actively in their product, for a better marketing effect (feels way more stable when a business is backing the development).

Alternatively I may move it over to my personal handle and add you folks as contributors.

What do you think?

PS: There's also a new rescript-express binding by @bloodyowl ... maybe it's even better joining force there?

ryyppy avatar May 15 '21 09:05 ryyppy

I saw that bloody owl had created a new set of bindings. That's awesome. Perhaps then it'd be a better idea to archive this repository and direct people there?

ncthbrt avatar May 17 '21 06:05 ncthbrt

it seems that bloodyowl's approach is geared more towards zero cost bindings, which is a little different to bs-express.

I guess if no one is actively relying on patches to these bindings we could just archive it then... worst case someone will revive the code anyways? I will ask around a little more and see if anyone is willing to take ownership.

ryyppy avatar May 17 '21 21:05 ryyppy