realm-core icon indicating copy to clipboard operation
realm-core copied to clipboard

PoC: Add MQL translation skeleton

Open jsflax opened this issue 2 years ago • 5 comments
trafficstars

jsflax avatar Nov 09 '23 13:11 jsflax

Pull Request Test Coverage Report for Build github_pull_request_285284

  • 264 of 308 (85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on jf/mql at 91.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/util/bson/bson.cpp 6 7 85.71%
src/realm/object-store/results.cpp 0 4 0.0%
src/realm/parser/query_bson.cpp 117 156 75.0%
<!-- Total: 264 308
Totals Coverage Status
Change from base Build 1854: 91.7%
Covered Lines: 231504
Relevant Lines: 252558

💛 - Coveralls

coveralls-official[bot] avatar Nov 13 '23 13:11 coveralls-official[bot]

Let's not merge this yet.

jsflax avatar Nov 20 '23 20:11 jsflax

@jsflax What is going to happen with this PR?

jedelbo avatar Jan 05 '24 14:01 jedelbo

Unclear right now– we need to road map this before moving forward with the actual feature.

However, if this is adding enough additional useful stuff, I'd be fine removing the MQL features from the header and then consider merging the rest.

jsflax avatar Jan 05 '24 15:01 jsflax

@jsflax you mean removing the changes to results.hpp? I am not sure what the risk of keeping it would be. I would prefer that we can keep the test.

jedelbo avatar Jan 08 '24 09:01 jedelbo