SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Published 20 hours ago • verified publisher icon realm

Switch to SwiftPM conditional dependencies API

Open keith opened this issue 3 years ago • 5 comments
trafficstars

This API allows us to mostly remove #if conditionals which enables cross compilation from macOS -> Linux. It also removes the thrashing of Package.resolved if you compile in a docker image.

keith avatar Jun 23 '22 09:06 keith

CI doesn't have unzip

keith avatar Jun 23 '22 09:06 keith

1 Message
:book: Skipping OSSCheck because SwiftLint hasn't changed compared to 'main'

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Jun 23 '22 09:06 SwiftLintBot

CI doesn't have unzip

Needs https://github.com/apple/swift-docker/pull/300

jpsim avatar Jun 24 '22 12:06 jpsim

Can you please rebase? There appear to be new docker images that should contain the fix: https://hub.docker.com/_/swift/tags

jpsim avatar Aug 09 '22 18:08 jpsim

🤞🏻

keith avatar Aug 15 '22 23:08 keith

Rebased and updated the PR.

SimplyDanny avatar Apr 16 '23 17:04 SimplyDanny

Could we revert binaryPlugin related changes? It seems Xcode will build swiftlint target regardless the platform condition.

Related: #4998

li-bei avatar May 14 '23 15:05 li-bei