reagent icon indicating copy to clipboard operation
reagent copied to clipboard

rename run! macro to react!

Open darwin opened this issue 10 years ago • 3 comments

under [org.clojure/clojurescript "0.0-3308"] it was shadowing clojure.core/run! and causing warning:

WARNING: run! already refers to: #'clojure.core/run! in namespace: reagent.ratom, being replaced by: #'reagent.ratom/run!

darwin avatar Jun 25 '15 16:06 darwin

See also #125

mike-thompson-day8 avatar Jun 26 '15 00:06 mike-thompson-day8

Thanks for the link.

AFAIK the problem with :refer-clojure is that it would have to be written in every file including ratom macros.

Also I think that run! name is unfortunate. It implies something which is run once and has side-effects. We need some better name which hints "this piece of code is being run multiple times in reaction to ratom changes".

darwin avatar Jun 26 '15 07:06 darwin

If we're going to go down this track, it would be good to go through a depreciation process for this. run! should still be usable for at least one more minor version series to let people update their code gracefully, and deprecation warnings should be printed when people use run!.

danielcompton avatar Aug 13 '15 00:08 danielcompton