sphinx_rtd_theme
sphinx_rtd_theme copied to clipboard
readthedocs
hlist: Make columns collapse when viewport is narrow
When the items of the hlist cannot fit into the viewport a collumn is split into a new row until the content fits.
This dramically improves mobile experience, for example https://docs.blender.org/api/current/bpy.types.AlphaUnderSequence.html will introduce horizonal scrolling on the whole viewport which causes visual glitchs with other content.
Fixes #1108
I would be in favor of dropping ie 11, the bug you show is avoidable on the user side if they set figwidth on the figure directive. The bug you show is also not present on all ie11 using browser stack, on windows 7 and ie 11 it displayed correctly for me. I bet the majority of users that use ie 11 are on windows 7.
There are also already issues with ie11 with the theme (see the logo) so maybe we go ahead and formally drop compatibility now. Also, the bug you show is similar to #1050 which affected all browsers maybe it is acceptable to introduce a minor regression. If we don't drop ie11 for 1.0 it might be a while until we release 2.0 (dropping ie should be part of a major release).
Does adding display: -ms-flexbox fix the bug? According to the docs I have read flex-flow is supported on ie11 without a prefix. If the solution is that simple, I can just add that and we can hold off on dropping ie11 a little longer.
Does adding display: -ms-flexbox fix the bug?
I did not test this. In theory it might though, IE11 requires a prefix on flex box rules for what support it did have.
There are also already issues with ie11 with the theme (see the logo)
This is a minor display issue for now, it probably doesn't warrant dropping ie11 support immediately by itself.
The bug you show is also not present on all ie11 using browser stack, on windows 7 and ie 11 it displayed correctly for me.
I tested on saucelabs ie11 + ~~win7~~ (edit: win10), against the PR build output.
Most recent update seems to have introduced vertical spacing between elements and did not fix the issue with overflow/wrap on the hlist caption:
Oops, I take that back. It also looks like you didn't rebuild assets yet, only the SASS source was updated. Trying this change manually does not alter the display however. Also, tested on win7 and win10 and no difference on ie11
Most recent update seems to have introduced vertical spacing between elements
I think that is a docutils 0.17 issue, rebased the patch on master and updated assets so hopefully, work as expected.
It would probably make more sense to revisit in 2.0, when we do drop IE11 support. Feel free to add IE11 support if you'd rather aim for a sooner release.