actions icon indicating copy to clipboard operation
actions copied to clipboard

Use actions/toolkit

Open LecrisUT opened this issue 2 years ago • 2 comments

The github actions documentation encourages using actions/toolkit

Ok, this one became more complicated than initially thought. Changing from a composite action to a js action requires a compilation step of a dist/index.js file. Not sure if it's worth having the additional steps.


:books: Documentation preview :books:: https://readthedocs-preview--30.org.readthedocs.build/en/30/

LecrisUT avatar Jun 08 '23 16:06 LecrisUT

Hi! I'm a little new on the GitHub Actions world. Can you please explain to me what are the benefits of actions/toolkit over the current pattern we are following here?

humitos avatar Jun 08 '23 19:06 humitos

Initially I thought it can make it cleaner and more in line with upstream documentation, but having to enforce a compilation workflow is a bit of a disadvantage. Maybe if we push compilation commits automatically, it wouldn't be that bad.

Other than that there can be some benefits:

  • One less checkout action to call and manage. All source is directly accessed by the current action caller. This also ensures that other gh action callers can use a fork version for testing
  • Simpler reusability
  • Allows to use external libraries from npm
  • Unit testing eventually

LecrisUT avatar Jun 08 '23 20:06 LecrisUT