async icon indicating copy to clipboard operation
async copied to clipboard

Remove unused $status property

Open kelunik opened this issue 3 years ago • 3 comments

kelunik avatar Aug 24 '22 18:08 kelunik

@kelunik Good catch, thanks for looking into this! It looks like this is indeed a small left-over from my changes in #55. May I ask you to squash your changes into a single commit?

clue avatar Aug 26 '22 09:08 clue

@clue Can just use squash on merge, no?

kelunik avatar Aug 26 '22 10:08 kelunik

@kelunik We try to avoid squashing changes via GitHub's squash on merge. This will always lead to GitHub being the new committer and it will also add an extra commit.

SimonFrings avatar Sep 05 '22 15:09 SimonFrings

@kelunik Checking if this ticket will receive any updates or can we close this? Been open for a while and we want to avoid having issues or pull requests laying around for too long.

It would involve squashing the two commits into one and then force pushing the new commit to GitHub in order for us to approve this. Or is there any way we can help this progressing?

SimonFrings avatar Feb 06 '23 10:02 SimonFrings

This ticket hasn't received any updated in a while, so I'll close this for now. We can always revisit this at a later time.

SimonFrings avatar Jun 22 '23 13:06 SimonFrings