async icon indicating copy to clipboard operation
async copied to clipboard

Published 20 hours ago • verified publisher icon reactphp

[4.x] Add template annotations to async and await

Open WyriHaximus opened this issue 3 years ago • 2 comments

These annotations will aid static analyses like PHPStan and Psalm to enhance type-safety for this project and projects depending on it.

This PR builds on the discussion at https://github.com/vimeo/psalm/discussions/7559 Once this PR goes up for review simular PR's will also be opened for v2 and v3 of this package. Depends on: https://github.com/reactphp/promise/pull/227

WyriHaximus avatar Mar 24 '22 07:03 WyriHaximus

@clue I assume most of the location related comments also go for the promise counter parts?

WyriHaximus avatar Jul 09 '22 20:07 WyriHaximus

+1+1+1

Needed to highlight how much I like this change despite all the nit-picking in this review. Keep it up!

Much appreciated @clue . Updated this PR, and https://github.com/reactphp/promise/pull/227 (and https://github.com/reactphp/promise/pull/228) with related changes.

WyriHaximus avatar Jul 09 '22 22:07 WyriHaximus