react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

Fixed broken placeholder links on manipulating dom with refs page

Open daniel-norris opened this issue 5 months ago • 5 comments
trafficstars

Hi, was looking at the page below and noticed a couple things...

  • the image placeholders we're retrieving from placecats.com is no longer working and I can't find the API documentation anymore
  • the images used for some of the other ref examples and solutions were all using the same image

image

image

image

Solution:

  • I've pointed all the examples to a new placeholder
  • They now generated an assortment of images and not just one
  • They're all dogs because dogs > cats

image

image

image

🐕‍🦺

daniel-norris avatar Jun 15 '25 18:06 daniel-norris

Hi @daniel-norris!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 15 '25 18:06 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jun 15 '25 18:06 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jun 15 '25 20:06 facebook-github-bot

I think we should just host them ourselves and do a pass to remove any external image links from the docs. Would you mind taking a look at that?

I'd also prefer to keep cats personally. But if you do the above, I can take dogs.

gaearon avatar Jun 16 '25 15:06 gaearon

One argument to keep cats is to avoid churning the translations.

gaearon avatar Jun 16 '25 15:06 gaearon

we should just host them

Sure ok, I can have a look at some options. Anything in particular you had in mind here? What about simply putting them in https://github.com/reactjs/react.dev/tree/main/public/images/docs/illustrations or similar?

One argument to keep cats is to avoid churning the translations.

That's fair enough.

daniel-norris avatar Jun 19 '25 18:06 daniel-norris