react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

chore(a11y): improving a11y score to 100% for homepage in both light/dark mode for mobile/desktop

Open StephNathai opened this issue 1 year ago • 3 comments
trafficstars

Details

  • Improves accessibility score to 100% for homepage in both light and dark mode across all devices
  • Used AxeDevTool for accessibility check
  • Closes issue 7233

Screenshots of Before/After fix

Mobile: Light Mode

mobile_light

Mobile: Dark Mode

mobile_dark

Desktop: Light Mode

desktop_light

Desktop: Dark Mode

desktop_dark

StephNathai avatar Oct 18 '24 18:10 StephNathai

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:43pm
react-dev ✅ Ready (Inspect) Visit Preview Oct 21, 2024 7:43pm

vercel[bot] avatar Oct 18 '24 18:10 vercel[bot]

Hi @StephNathai!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 18 '24 18:10 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.37 KB (-6 B) 208.68 KB
/500 104.37 KB (-6 B) 208.67 KB
/[[...markdownPath]] 106.22 KB (-6 B) 210.52 KB
/errors 104.58 KB (-6 B) 208.89 KB
/errors/[errorCode] 104.56 KB (-6 B) 208.86 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Oct 18 '24 18:10 github-actions[bot]

Hi team, can we get this accessibility fix reviewed/merged please?

StephNathai avatar Jan 10 '25 16:01 StephNathai