react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

fix: use path.basename to ensure cross-platform compatibility

Open aiyemomi opened this issue 1 year ago • 4 comments
trafficstars

Replaced filePath.split('/').slice(-1).join('') with path.basename(filePath) to correctly extract the file name from the file path. This ensures the code works correctly on all operating systems, including Windows, macOS, and Unix-like systems, which use different path separators."

aiyemomi avatar Jun 13 '24 16:06 aiyemomi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 4:39pm
react-dev ✅ Ready (Inspect) Visit Preview Jun 13, 2024 4:39pm

vercel[bot] avatar Jun 13 '24 16:06 vercel[bot]

Hi @aiyemomi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 13 '24 16:06 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jun 13 '24 16:06 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jun 13 '24 16:06 facebook-github-bot