react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

/errors: Empty args are not missing arguments

Open eps1lon opened this issue 1 year ago • 2 comments
trafficstars

e.g. the hydration diff will always produce /errors/418?args[]= in prod because prod doesn't have diffs. This displayed a [missing-argument] which isn't accurate.

Includes drive-by fix for https://github.com/reactjs/react.dev/issues/6734

Preview:

  • https://react-dev-git-fork-eps1lon-empty-error-decoder-fbopensource.vercel.app/errors/418?args[]=
  • Still shows missing if args[] is absent: https://react-dev-git-fork-eps1lon-empty-error-decoder-fbopensource.vercel.app/errors/418

eps1lon avatar Apr 20 '24 20:04 eps1lon

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:53am
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:53am

vercel[bot] avatar Apr 20 '24 20:04 vercel[bot]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 105.96 KB (-4 B) 210.34 KB
/500 105.96 KB (-4 B) 210.33 KB
/[[...markdownPath]] 107.75 KB (-4 B) 212.12 KB
/errors 106.17 KB (-4 B) 210.55 KB
/errors/[errorCode] 106.15 KB (-4 B) 210.53 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Apr 20 '24 20:04 github-actions[bot]