react.dev
react.dev copied to clipboard
fix: Fix word component(s) capitalization
This pr fixes the word component(s) capitalization for issue #6713
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 22, 2024 1:14am |
Hi @anthonylaflamme!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Size changes
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
79.75 KB (🟡 +8 B) |
183.65 KB |
/500 |
79.75 KB (🟡 +8 B) |
183.65 KB |
/[[...markdownPath]] |
81.53 KB (🟡 +8 B) |
185.43 KB |
/errors |
79.93 KB (🟡 +8 B) |
183.83 KB |
/errors/[errorCode] |
79.91 KB (🟡 +8 B) |
183.8 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
just signed the CLA
there is two instances of the word "subcomponent" should these be sub Components or we leave them as is ?
I also wonder about places where we talk about HTML Element but refer to them as component ex:
" The built-in browser <link> Component lets you use external resources such as stylesheets or annotate the document with link metadata."
This might be out of scope for this PR but should these be Element instead of Component ?
@anthonylaflamme thanks for taking a stab!
Can you revert the homepage, /blog and /community changes? Let's just keep those as-is.
Can you also revert the capitalization for things that are not referring to the React Component concept directly? I update https://github.com/reactjs/react.dev/issues/6713 with a style guide to try and make it clearer when to capitalize.
Some example from this PR that should not be capitalized:
- "the
<link>component" - "such as preserving
thiscontext inside a component" - "can update 50,000+ components alone"
- "upgrade your apps one component at a time"
Admittedly this is tricky, my mental model for this is "would it make sense to link to the docs for components here" or "could this be replaced with 'React Component'"?
Thank you for making this more precise. I will continue to update them as I read through the context of some of them I should be able to pull this in a timely manner.
Do I have to do this with all the file's out there, Tell me and assign this issue I will do it!