react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Capitalized State

Open haroon6268 opened this issue 1 year ago • 4 comments
trafficstars

Hello, today was my first time doing a pull request so please let me know if I am doing anything wrong. I capitalized state in the adding-interactivity.md file.

haroon6268 avatar Mar 27 '24 04:03 haroon6268

Hi @haroon6268!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 27 '24 04:03 facebook-github-bot

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Mar 27, 2024 4:21am

vercel[bot] avatar Mar 27 '24 04:03 vercel[bot]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Mar 27 '24 04:03 github-actions[bot]

Hey there @haroon6268! 👋

https://github.com/reactjs/react.dev/issues/6713#issue-2209791402 has been updated with a brief style guide for what instances of the terms should be capitalized, and what should remain lowercase. Could you please:

  1. Read through https://github.com/reactjs/react.dev/issues/6713#issue-2209791402 again (it's been edited a lot in the past few days)
  2. Update your pull request (just push the commit to the capitalized-state branch in your fork and GitHub with automatically update it here).

I think there's a few instances in your PR that should stay lowercase, for example

Instead, when you want to update an object and array, you need to create a new one (or make a copy of an existing one), and then update the State to use that copy.

Not an expert on this, though. Maybe @rickhanlonii can confirm?

In any case, thanks for the contribution! You're on the way to a great PR. I hope this was helpful. ❤️

pwbriggs avatar Apr 04 '24 07:04 pwbriggs