Update and fix gh actions

[alinkedd]

trafficstars

• Updated external actions to the latest version (except for the upload-artifact). Close #5961 (partially)
  • upload-artifact was bumped to v3, as I'm not sure about the required unique artifact names in v4, though v3 still uses node16. Also close #7148
• Fixed the warning of uploading missing files if previous comparing analysis steps were canceled. (As an example, you may check this warning in the annotations section here: https://github.com/reactjs/react.dev/actions/runs/7980888987 or directly in the logs here: https://github.com/reactjs/react.dev/actions/runs/7980888987/job/21791474787 in the Upload analysis comment step)
• Fixed Analyze Bundle (Comment) action failure on the default branch by rewriting the condition, as GitHub's runner evaluation is tricky and sometimes provides false positives. Close #5801

NOTE: analyze-comment depends on workflow_run and thus will be used only after merging updates into the default branch. This is why the deprecation warning is still present (https://github.com/reactjs/react.dev/actions/runs/7980542658). To check the proposed fix in a condition, you may look over the same fix in my test repo and then dependant workflow respecting that condition.

Thorough review is welcomed, as I'm no GitHub Actions professional :)

UPD I added folded block to if condition without expression to shorten the line, and it seems to work file. Links to my latest test results are updated.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 16, 2024 9:23pm

[github-actions[bot]]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[alinkedd]

@gaearon @harish-sethuraman could you please help to find someone to review this PR regarding GH actions? It would be great to have them fixed.

duplicates https://github.com/reactjs/react.dev/pull/6179#issuecomment-1955047477 fyi @rickhanlonii