react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

update createPortal docs to use a specific portal node

Open souporserious opened this issue 1 year ago • 3 comments
trafficstars

The docs for createPortal currently mention to use document.body as the main example of a portal node to use. However, this pattern is a footgun and can lead to a full style re-calculation of the body when the node is updated.

This PR updates the createPortal docs to refer to creating a specific portal node to render into that avoids this. Please see this article for a detailed explanation of the issue.

souporserious avatar Jan 25 '24 18:01 souporserious

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ❌ Failed (Inspect) Jan 25, 2024 6:33pm

vercel[bot] avatar Jan 25 '24 18:01 vercel[bot]

Hi @souporserious!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 25 '24 18:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 25 '24 20:01 facebook-github-bot