react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Minor Code improvements

Open prajwalkulkarni opened this issue 1 year ago • 2 comments
trafficstars

:dizzy: Changelog

:star: Update "show arrow" condition in the SidebarLink component. :star: Use strict equality operator wherever the type of operand(s) are known.

prajwalkulkarni avatar Jan 22 '24 13:01 prajwalkulkarni

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.87 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.1 KB (🟡 +1 B) 182.97 KB
/500 79.1 KB (🟡 +1 B) 182.96 KB
/[[...markdownPath]] 80.69 KB (🟡 +1 B) 184.56 KB
/errors 79.28 KB (🟡 +1 B) 183.15 KB
/errors/[errorCode] 79.26 KB (🟡 +1 B) 183.13 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Jan 22 '24 13:01 github-actions[bot]

@rickhanlonii could you kindly review the changes?

prajwalkulkarni avatar Jan 26 '24 15:01 prajwalkulkarni