react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Fix missing id properties in docs example

Open jpayoung opened this issue 2 years ago • 3 comments
trafficstars

The docs page for rendering lists uses a list of people as example. Where id properties are first introduced (i.e. the "data is structured"), two of the objects in the list are missing ids. This might cause confusion to new readers.

The absence of or these two objects appears to be a mistake. Where the list of people is next referenced, all 5 objects have ids. They are not added as an exercise or example anywhere in between.

This change adds those two missing ids. Thanks!

jpayoung avatar Oct 29 '23 05:10 jpayoung

Hi @jpayoung!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 29 '23 05:10 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Oct 29 '23 05:10 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Oct 29 '23 06:10 facebook-github-bot