react.dev
react.dev copied to clipboard
reactjs
fix: spacing in responsive site navigation
This fixes the following issue: https://github.com/reactjs/reactjs.org/issues/5725
::-webkit-scrollbar offsets its containing element's width in browsers that support it.
This PR overlays the scrollbar so the containing element's width is not affected (and adds the appropriate padding/margin to even out the spacing in mobile).
Chrome (before):
Chrome (after):
Firefox (before):
Firefox (after):
Also removes overflow-x-scroll on top navigation items because it doesn't seem to be needed?
Chrome (before):
Chrome (after):
Hi @safiranugroho!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Size Changes
📦 Next.js Bundle Analysis
This analysis was generated by the next.js bundle analysis action 🤖
⚠️ Global Bundle Size Increased
| Page | Size (compressed) |
|---|---|
global |
92.97 KB (🟡 +5 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
75.68 KB (🟡 +12 B) |
168.65 KB |
/500 |
75.67 KB (🟡 +12 B) |
168.65 KB |
/[[...markdownPath]] |
77.09 KB (🟡 +12 B) |
170.07 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
In safari Im still getting the scrollbar with this branch preview?
Im curious why you did not do you might want to do -webkit-appearance: none; for -webkit-scrollbar?
i didn’t write the impl. for the scrollbar, but i assume the idea is to set a transparent background color instead of hiding it completely.
in the source code scrollbar-color is defined, but since only Firefox supports that property, -webkit-scrollbar is used as fallback to achieve the same behavior (set transparent background color).
my PR is to fix the fact that -webkit-scrollbar offsets the width of its containing div, bc i didn’t want to disturb the original implementation.
with overflow-y: overlay it puts the -webkit-scrollbar as an overlay on top of the content instead of taking up space in the containing div.