react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

docs: remove render prop unreachable link

Open nidhi-tandon opened this issue 2 years ago • 4 comments
trafficstars

Current state:

The link on "render props" and "any prop that is a function that a component uses to know what to render is technically a “render prop" " is https://cdb.reacttraining.com/use-a-render-prop-50de598f11ce and it does not work.

Proposed state:

Remove the unreachable link

Best state:

Update the link with a working link. (which I am not sure of right now, so better state is to improve UX)

nidhi-tandon avatar Mar 06 '23 10:03 nidhi-tandon

Hi @nidhi-tandon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 06 '23 10:03 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Mar 06 '23 10:03 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 06 '23 11:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 06 '23 11:03 facebook-github-bot