react.dev
react.dev copied to clipboard
Refactor to adhere to React best practices
In this section, the words "fetched," "fetching," and "onFetched" are used frequently. so, including useSomeAPI() without any clarification in the example may cause confusion as it could be interpreted as a side effect. To clarify, it should be noted that useSomeAPI() is a side effect and should be wrapped in an useEffect() hook or an event handler to avoid potential issues.
To eliminate any confusion, either the wording used in the example can be modified, or it can be explicitly mentioned that useSomeAPI() should be wrapped in an useEffect() hook or an event handler. By doing so, it will ensure that the example follows React's best practices, which suggest that data should flow from parent components to their children, and updates to parent component state should not be made in child component effects.
Overall, making this clarification will improve the clarity of the example and prevent potential confusion for readers.
Hi @cipherlogs!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Size Changes
📦 Next.js Bundle Analysis
This analysis was generated by the next.js bundle analysis action 🤖
This PR introduced no changes to the javascript bundle 🙌
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!