react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

feat: add progress bar to avoid feeling like being blocked while navigating between pages

Open halisyucel opened this issue 2 years ago • 3 comments
trafficstars

While reading the beta documentation, I realized there was one part that didn't look good to me. While navigating between pages, the absence of a "loading" screen made me feel as if the page was crashing and freezing for a moment. That's why I added a progress bar at the top of the site to match the design.

This progress bar makes navigating between pages more comfortable, especially for those with a slow connection.

You can see the visual change from this link

halisyucel avatar Feb 22 '23 17:02 halisyucel

Hi @halisyucel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 22 '23 17:02 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 92.3 KB (🟡 +3.12 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Feb 22 '23 17:02 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 22 '23 19:02 facebook-github-bot