react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Improved createRoot() example

Open adriancuadrado opened this issue 3 years ago • 7 comments
trafficstars

adriancuadrado avatar Sep 04 '22 02:09 adriancuadrado

Hi @adriancuadrado!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 04 '22 02:09 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Sep 04 '22 02:09 github-actions[bot]

Thanks but we don’t plan to be changing the current docs — would you take a look at the version on beta.reactjs.org and whether you’re satisfied with the example there?

gaearon avatar Sep 04 '22 03:09 gaearon

It's been 2 hours and the system hasn't detected my CLA yet. Why? This other PR I also made detected my CLA and according to the details of the missing CLA check it should take no more than 1 hour:

image image

adriancuadrado avatar Sep 04 '22 03:09 adriancuadrado

@gaearon How do I edit the beta.reactjs.org version? I don't see any Edit this page button anywhere as most articles do in reactjs.org. There seems to be many beta branches. Which one should I submit PRs to? image

adriancuadrado avatar Sep 04 '22 03:09 adriancuadrado

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Sep 04 '22 04:09 facebook-github-bot

It's on the main branch in the beta folder.

gaearon avatar Sep 04 '22 16:09 gaearon