react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

[beta] Accessibility update text colors

Open Arhell opened this issue 3 years ago • 6 comments
trafficstars

resolve https://github.com/reactjs/reactjs.org/issues/4916

Arhell avatar Aug 20 '22 21:08 Arhell

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 82.47 KB (🟡 +42 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.68 KB (🟡 +15 B) 126.15 KB
/500 43.66 KB (🟡 +15 B) 126.13 KB
/[[...markdownPath]] 43.74 KB (🟡 +15 B) 126.22 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Aug 20 '22 21:08 github-actions[bot]

Can you please provide screenshots before/after for specific parts you changed? We'd also want to avoid hardcoding colors. If we need a new shade of blue, I think we should add it to the config. Thank you!

gaearon avatar Sep 07 '22 20:09 gaearon

Can you please provide screenshots before/after for specific parts you changed? We'd also want to avoid hardcoding colors. If we need a new shade of blue, I think we should add it to the config. Thank you!

After update before Screenshot_1

after Screenshot_2

there it is not noticeable to the eye, but the Accessibility Insights for Web application no longer produces errors

Arhell avatar Sep 07 '22 23:09 Arhell

before https://beta.reactjs.org/

after https://beta-reactjs-p90mi4tze-fbopensource.vercel.app/

Arhell avatar Sep 08 '22 00:09 Arhell

we keep the colors in colors.js which is referenced from the tailwind config. would you mind adding a proposed color there and matching the existing naming scheme? thanks!

gaearon avatar Sep 08 '22 02:09 gaearon

we keep the colors in colors.js which is referenced from the tailwind config. would you mind adding a proposed color there and matching the existing naming scheme? thanks!

fix & update https://beta-reactjs-p90mi4tze-fbopensource.vercel.app/

Arhell avatar Sep 22 '22 14:09 Arhell