react-router-tutorial

react-router-tutorial copied to clipboard

Lesson 13 - Rending HTML for root path ('/')

2

Following the lesson 13 tutorial I wasn't able to render the full server side HTML for the root path ('/'). This is a very important thing for apps that relies...

pisrael

These instructions are very obvious for someone who has some experience programming with node, but just to avoid beginners getting stuck.This commit adds "cd 02-rendering-a-route" and "npm install" to instructions.

acucciniello

misleading webpack.config snippet code

2

if you follow the lesson and copy the path param in the webpack config snippet code ``` // webpack.config.js output: { path: 'public', filename: 'bundle.js', publicPath: '/' } ``` that...

wayann

change app.use(express.static(path.join(__dirname, 'public'))) to: app.use(express.static(path.join(__dirname, 'public'), {index: false}))

rajaraodv

In this patch, the navigation list is changed such that the proper HTML navigation element is used.

aaronang

Fixes #264

bsyk

Suggestion: Call-out that links are absolute

1

In lesson 03-navigating-with-link it's suggested that: ``` It's almost identical to the tag you're used ``` While this is true, the *almost* is really understated here. I foolishly expected relative...

bsyk

Share node packages between lessons

2

Is it just me or is it a bit annoying to have to install node modules for each lesson? Would it not make more sense to share the packages?

nojaf

Error: Location "lessons/11-productionish-server/index.html" did not match any routes

1

I want people visit my project via "http://www.*****.com" so i use the following to output：  then i import this bundle.js in the html, code as follow: ``` My...

catliuqh

Removing '.' from package.json

2

With this . in the current location location, 'npm start' will throw an error.

DaveVoyles