react-rails icon indicating copy to clipboard operation
react-rails copied to clipboard

Prevent react_ujs from depending on itself

Open erikt9 opened this issue 3 years ago • 1 comments

Summary

Doesn't make any sense for a package to depend on itself.

If you import react_ujs manually from npm, the package-lock entry for it looks like

"react_ujs": {
      "version": "2.6.2",
      "resolved": "https://registry.npmjs.org/react_ujs/-/react_ujs-2.6.2.tgz",
      "integrity": "sha512-4WH91hVZp0533LsTjbcd9uI9xS/7/e4QkFbDpDjy8Pr7GuUt1gE+cM0zml7Ii9aSUDl2A/zzkUrLN5X9akmViQ==",
      "requires": {
        "react_ujs": "^2.6.1"
      }
    }

erikt9 avatar May 27 '22 00:05 erikt9

This seems legit. Any special testing for this?

justin808 avatar Aug 10 '22 05:08 justin808

Thanks @erikt9!

justin808 avatar Aug 15 '22 22:08 justin808