react-modal

react-modal copied to clipboard

Accessibility issues with the codepen demos

7

### Summary: Many of the [demos linked to from the README](https://github.com/reactjs/react-modal#demos) have accessibility issues: * [Minimal example](https://codepen.io/claydiffrient/pen/KNxgav) - once the modal is opened, `aria-hidden="true"` is set on the ``. this...

patrickhlauke

Body class not removed under certain circumstances

22

### Summary: If React Modal is mounted and almost immediately unmounted, the body's class is not removed when the modal disappears. If this class is used to prevent scrolling, the...

Plygon

Pressing enter key to close button closes the modal but the event is attached to opener element and reopens the modal

10

### Summary: ### Steps to reproduce: 1. Visit my demo on Codesandbox https://codesandbox.io/s/react-modal-vivyxc?file=/src/index.js 2. Click 'Open Modal' button and press `Tab`. This will focus the close button 3. Press `Enter`...

shawnscoding

Don't scroll parent component when Modal is opened

51

**Summary**: Don't scroll parent component when Modal is opened **Steps to reproduce:** 1. Implement a Modal 2. Open the Modal 3. The parent component of the Modal is still scrollable...

rahulthewall

Question: Why doesn't react-modal use imperative style?

11

### Summary: Why doesn't `react-modal` use imperative style? I mean, following: ```javascript class MyComponent extends Component { constructor() { super(); ... this.modal = ... ... this.handleClick = this.handleClick.bind(this); } handleClick()...

Webbrother

Switch from KeyboardEvent.keyCode to KeyboardEvent.code

2

Hi! First of all, apologies for removing the issue template—since this isn't a bug report, I've found it hard to fill the reproduction steps. I'm wondering if there's anything stopping...

robinmetral

Transition does not work with custom class names in CSS modules

3

### Summary: The transition does not work when using a custom class name on the modal and when using CSS modules ```js Content ``` ```sass .modalOverlay position: fixed top: 60px...

realmayus

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. Changelog Sourced from eventsource's changelog. 1.1.1 Do not include authorization and cookie headers on redirect to different origin (#273 Espen Hovlandsdal) Commits aa7a408 1.1.1...

dependabot[bot]

### Summary: Accessibility issue with focus ### Steps to reproduce: 1. Open demo provided is demo section https://codepen.io/claydiffrient/pen/KNxgav 2. Switch on Scree Reader (NVDA + Chrome+ Windows in my case)...

ElenaShevchenko

Opening link in new tab prevents modal from closing after single click on overlay

1

### Summary: If modal content has a link inside, and this link is opened in new tab, the modal enters a state where it requires a click anywhere before it...

fenok