ReactiveUI.Samples icon indicating copy to clipboard operation
ReactiveUI.Samples copied to clipboard

[BUG] Commands names violates documented convention

Open LeiYangGH opened this issue 3 years ago • 0 comments
trafficstars

Describe the bug The doc Command Names says:

Don't suffix ReactiveCommand properties' names with Command; instead, name the property using a verb that describes the command's action. For example:

public ReactiveCommand Synchronize { get; private set; }

But the sample code can find violations everywhere, just name a few:

CalculateCommand https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Basics/ViewModels/CalculatorViewModel.cs

StartAsyncCommand https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Commands/RxUI/MainVIewModel.cs

LeiYangGH avatar Dec 07 '21 15:12 LeiYangGH