react-workspaces-playground icon indicating copy to clipboard operation
react-workspaces-playground copied to clipboard

Published 20 hours ago • verified publisher icon react-workspaces

Why @react-workspaces/react-scripts and react-scripts required as dependencies in same app

Open Jagatmachines opened this issue 5 years ago • 2 comments

https://github.com/react-workspaces/react-workspaces-playground/blob/243028104739e7ecdc15488b199d80ab39d79fa5/packages/components-typescript/package.json#L24

Jagatmachines avatar Feb 20 '20 05:02 Jagatmachines

Well whoever committed that line was obviously an idiot.

Care to remove and submit PR?

F1LT3R avatar Apr 29 '20 00:04 F1LT3R

Just a heads-up, I have removed react-scripts and starting getting issues with import of svg files, after some research I found that https://github.com/facebook/create-react-app/issues/8223

That means that after you remove the react-scripts, you will need to modify all react-app-env.d.ts files from:

/// <reference types="react-scripts" />

to

/// <reference types="@react-workspaces/react-scripts" />

After I have done that, the imports worked again. Obviously that is relevant only for people using Typescript.

alanrubin avatar May 06 '20 07:05 alanrubin