react-ui icon indicating copy to clipboard operation
react-ui copied to clipboard

Code owners are set to strict that vacation of just one member can result in unability to merge

Open bedrich-schindler opened this issue 7 months ago • 2 comments

Our CODEOWNERS file looks like this:

# Default owners for code review
*              @developers

# Default owners for file types
*.js           @mbohal @bedrich-schindler @developers
*.jsx          @mbohal @bedrich-schindler @developers
*.md           @adamkudrna @developers
*.scss         @adamkudrna @developers

# Default owners for directories
/docker        @mbohal @bedrich-schindler @developers
/src/docs      @adamkudrna @developers

# Default owners for specific files
/.browserslistrc            @adamkudrna @developers
/.eslintrc                  @mbohal @bedrich-schindler @developers
/.markdownlint.jsonc        @adamkudrna @developers
/babel.config.js            @mbohal @bedrich-schindler @developers
/docker-compose.yml         @mbohal @bedrich-schindler @developers
/jest.config.js             @mbohal @bedrich-schindler @developers
/postcss.config.js          @adamkudrna @developers
/stylelint.config.js        @adamkudrna @developers
/webpack.config.babel.js    @mbohal @bedrich-schindler @developers

This can result in required review of a member that is on a vacation. We cannot block the work by someone's time off.

bedrich-schindler avatar May 01 '25 07:05 bedrich-schindler

I would suggest creating several groups like @reviewers-styles, @reviewers-javascript, @reviewers-documetation, @reviewers-stack or so. If am right, then it would require to have approval from just one member of the group, not the exact person.

Docs: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

bedrich-schindler avatar May 01 '25 07:05 bedrich-schindler

Today we decided that @adamkudrna will look at it.

bedrich-schindler avatar May 05 '25 18:05 bedrich-schindler