react-native-callkit icon indicating copy to clipboard operation
react-native-callkit copied to clipboard

EndCall fix

Open eugenehp opened this issue 8 years ago • 5 comments

https://github.com/ianlin/react-native-callkit/issues/3

as explained here http://stackoverflow.com/questions/38793722/error-while-requesting-a-transaction-with-cxendcallaction

eugenehp avatar May 03 '17 19:05 eugenehp

Hey @eugenehp thanks for this.

In my case using either action.UUID or action.callUUID works as expected. From the log output the value of action.UUID is different from that of action.callUUID while action.callUUID is identical to the uuid I pass when calling startCall react method.

This is a bit weird.. Can you please share some information about your environment like the iOS version and how you use this module?

Thanks!

ianlin avatar May 05 '17 08:05 ianlin

Hi @ianlin , this PR works for this issue. #3 Hope this one will be merge soon.

joshuaalpuerto avatar Jul 10 '17 03:07 joshuaalpuerto

@eugenehp Can you please resolve conflict?

sujameslin avatar Feb 22 '18 17:02 sujameslin

According to the apple doc UUID in reportCallWithUUID:(NSUUID *)UUID is

The unique identifier of the call.

Whereas, UUID of CXAction object is

The unique identifier for the action.

and callUUID of CXCallAction object is

The unique identifier for the call associated with the action.

I believe we should stick to the current version where we pass startCallAction.callUUID.

@eugenehp @ianlin @sujameslin Guys, can we close this one?

aarkalyk avatar Feb 23 '18 15:02 aarkalyk

That needs to be merged. I have also same issue #3 . It is not closed and after a while I am getting "CALL FAILED" message.

zek avatar Oct 18 '18 00:10 zek