react-native-callkeep icon indicating copy to clipboard operation
react-native-callkeep copied to clipboard
verified publisher icon react-native-webrtc

Don't try to get phone account if self managed when creating a connection

Open donaldkwong opened this issue 2 years ago • 8 comments

We want to use CallKeep without requesting READ_PHONE_STATE permissions on Android, which should be possible if we're in self managed state. However, the connection creation code in VoiceConnectionService always tries to get the phone account, which requires that permission to be granted. This diff adds a check to see if we're in self managed mode and, if so, don't try to get the phone account.

donaldkwong avatar Apr 20 '23 21:04 donaldkwong

@donaldkwong hey man, why did you close this PR?

wilmxre avatar May 30 '23 09:05 wilmxre

Thanks @donaldkwong, can you add a little bit of documentation for this behaviour ?

manuquentin avatar Jul 31 '23 18:07 manuquentin

@manuquentin , what were you thinking of in terms of documentation? Changes to README.md or code comments?

donaldkwong avatar Jul 31 '23 22:07 donaldkwong

Can you put changes in the README please ?

manuquentin avatar Jul 31 '23 22:07 manuquentin

Honestly not sure what to write in the README since this feels more like a bug fix than a feature, but I added a description of the behavior.

donaldkwong avatar Aug 01 '23 00:08 donaldkwong

I don't have permission to merge this PR. Can someone do it for me?

donaldkwong avatar Aug 04 '23 02:08 donaldkwong