react-native-callkeep icon indicating copy to clipboard operation
react-native-callkeep copied to clipboard
verified publisher icon react-native-webrtc

Fix android build errors with RN 0.74

Open ramijarrar opened this issue 2 years ago • 4 comments

After updating to React Native 0.71, we are getting build failures on Android (including #646).

This PR makes the following changes to resolve these:

  • Add redundant handling for missing permission exceptions. Existing checks work but do not satisfy lint, so this is the only way to resolve https://github.com/react-native-webrtc/react-native-callkeep/issues/646

  • Upgrade gradle to maximum compatible version (3.6.4) to satisfy new minimum (3.2.0)

  • Use AudioManager.MODE_NORMAL constant explicitly (instead of the equivalent value of "0" currently being used) to satisfy lint

  • Replace deprecated WindowManager.LayoutParams constants with Activity API methods when using Android SDK v27+

ramijarrar avatar Apr 15 '23 06:04 ramijarrar

@saghul please review this

santhoshvai avatar Jun 05 '23 10:06 santhoshvai

Sorry I'm not familiar enough with this project to give a proper review.

Personally, bumping the minimum SDK to 27 sounds like it would leave too many users out.

saghul avatar Jun 05 '23 11:06 saghul

@manuquentin I've updated the PR to maintain compatibility with older platform versions.

ramijarrar avatar Oct 31 '23 09:10 ramijarrar

@manuquentin Can you please advise if there any further changes you would like to get this merged? Thanks!

ramijarrar avatar Jun 13 '24 03:06 ramijarrar