voice icon indicating copy to clipboard operation
voice copied to clipboard

feat(Android): skip sending event when onResults/onPartialResults receive empty array

Open aladine opened this issue 1 year ago • 0 comments

Context:

  • In onResults/onPartialResults sometimes we get empty string and on ReactNative application, we don't need empty string from voice response.
  • To save the roundtrip network call via the bridge, I think it is better to filter out empty string from the array sending via event.
  • Many dependencies are outdated and worth to upgrade.

Proposed changes:

  • Add empty string check before pushing result to array in onResults/onPartialResults
  • Update gradle to 8.3 when open the project as a stand alone project in IDE
  • Replace jcenter to mavenCentral since jcenter is deprecated
  • Update com.android.support:appcompat to androidx equivalent dependency, the default version is 1.2.0

aladine avatar Apr 03 '24 18:04 aladine