completionHandler not called by finish()?

[anthonylinbp]

It's my understanding that we must call the completionHandler after handling remote notifications. As specified in the README under the section for finish(), it says:

"If you do not call this method your background remote notifications could be throttled, to read more about it see the above documentation link."

But after this change, #241, it looks like the completionHandler is never actually called by finish().

All finish() does is call this method (onFinishRemoteNotification):

RCT_EXPORT_METHOD(onFinishRemoteNotification:(NSString *)notificationId fetchResult:(UIBackgroundFetchResult)result) { [self.remoteNotificationCallbacks removeObjectForKey:notificationId]; }

which just removes it from the remoteNotificationCallbacks dictionary without calling it.

Is completionHandler actually being called somewhere?

[joebernard]

I don't even see finish being called in the example app. Very confused how this is implemented.

https://github.com/react-native-push-notification/ios/blob/master/example/App.js

[nicolas6422]

lol, I thought I was losing my mind, this is just broken

[majirosstefan]

Seems like it's back https://github.com/react-native-push-notification/ios/commit/dd46810d08d32264a49507a665249cd492b13574