masked-view icon indicating copy to clipboard operation
masked-view copied to clipboard

Published 20 hours ago • verified publisher icon react-native-masked-view

Support new React Native new architecture (TurboModules/Fabric)

Open tom-sherman opened this issue 3 years ago • 6 comments

See https://reactnative.dev/docs/new-architecture-library-intro

https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

tom-sherman avatar Jun 23 '22 09:06 tom-sherman

Hi @tom-sherman

I'm working in this support https://github.com/react-native-masked-view/masked-view/pull/164

unfernandito avatar Jul 06 '22 01:07 unfernandito

@tom-sherman currently, fabric for android is full working, you can try my fork if you want.

iOS Fabric is barely supported in my fork, not crash but right now I'm stuck with this issue when you try to use the lib:

image

I guess the issue is in the UIManager and how it works under fabric architecture but I'm pretty lost, I'll continue searching for a solution

unfernandito avatar Jul 06 '22 21:07 unfernandito

I started a new discussion about this issue

https://github.com/reactwg/react-native-new-architecture/discussions/80

hansdesmedt avatar Oct 04 '22 08:10 hansdesmedt

hey @unfernandito I created a PR on your PR, can you check and merge both into this lib? Thx!

issues fixed:

  • fix build for android
  • fix masked view for iOS fabric build

https://github.com/unfernandito/masked-view/pull/3

hansdesmedt avatar Oct 10 '22 09:10 hansdesmedt

or I can create a PR with the changes of @unfernandito and mine directly into this repo?

hansdesmedt avatar Oct 10 '22 09:10 hansdesmedt

Hey, yes i Will check your pr

unfernandito avatar Oct 10 '22 13:10 unfernandito

Any updates?

aleksey-mukho avatar Mar 24 '23 15:03 aleksey-mukho