google-signin
google-signin copied to clipboard
[wip] add jest mock
Is there something missing which prevents merge to master?
yeah, I wanna make this a little more flexible by allowing to choose mocking success / cancel / other cases. Just need to find some extra time for this.
For future readers, isSignedIn is missing:
isSignedIn: jest.fn(() => Promise.resolve(true)),
Hey guys ! Just wondering if there is any plan to continue this PR ?
https://github.com/react-native-community/google-signin/issues/164#issuecomment-557914018 appears to be another attempt at a mock for this package. I'd say merging a default mock would be helpful. Consumers can use the Jest API to make it return other values. Not really sure how else you'd make a customizable mock and haven't seen it done in other packages but I'd be curious about how to make one.
May I know why is it still open?
Hey @vonovak 👋, would be nice to see this PR get over the line, what do you have left to do. I wouldn't mind getting involved and help contribute.
hmm, yeah, after 4 years I might finally push it over the line.. 😆 give me a week or so pls
:tada: This PR is included in version 8.1.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
@vonovak Legend!! I suspect this will be huge for folks wanting to test Google Sign In 🚀