react-native-elements-app icon indicating copy to clipboard operation
react-native-elements-app copied to clipboard

Fix Typescript Errors

Open flyingcircle opened this issue 4 years ago • 8 comments

I have recently converted all of the code to typescript. It should still compile just fine, but it would be nice to have the demo app be a good check on the correctness of the developer experience of using the library.

There are a lot of hanging typescript errors. This would be to go through and fix them so that tsc passes cleanly.

flyingcircle avatar Mar 16 '21 02:03 flyingcircle

I would like to take up this, and fix the issues.

khushal87 avatar Mar 16 '21 03:03 khushal87

@flyingcircle Can you assign me this issue?

khushal87 avatar Mar 16 '21 04:03 khushal87

The rest of the issues are coming up from the package react-native-elements therefore this can be closed. @flyingcircle

khushal87 avatar Mar 28 '21 17:03 khushal87

I'd prefer this stay open. If there's an issue showing up here, then we need a ticket written in RNE for it to be solved.

flyingcircle avatar Mar 28 '21 18:03 flyingcircle

The ticket is already there. I am working on the potential fixes of the same in the package. Reference - https://github.com/react-native-elements/react-native-elements/issues/2870 @flyingcircle

khushal87 avatar Mar 28 '21 18:03 khushal87

Great. Let's keep the ticket open here so that when it's done, we can validate that it's fixed here before closing.

flyingcircle avatar Mar 28 '21 18:03 flyingcircle

Yes. @flyingcircle

khushal87 avatar Mar 29 '21 12:03 khushal87

I will try to handle the strict mode issues too soon. @flyingcircle Can I do so?

khushal87 avatar Mar 31 '21 06:03 khushal87