hooks icon indicating copy to clipboard operation
hooks copied to clipboard

setKeyboardShown in willshow and willhide

Open phuocantd opened this issue 4 years ago • 2 comments

Summary

resolve issue: https://github.com/react-native-community/hooks/issues/286

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android
Web

Checklist

  • [X] I have tested this on a device and a simulator
  • [ ] I added the documentation in README.md
  • [ ] I updated the typed files (TS and Flow)
  • [ ] I've created a snack to demonstrate the changes: LINK HERE

phuocantd avatar Nov 29 '21 04:11 phuocantd

This seems like quite a breaking change, and I don't think that this is what everyone wants (not that everyone wants what we currently have though 😅)

I think that the approach taken in #140 or potentially #168 is a better approach. What do you think about those?

LinusU avatar Nov 29 '21 08:11 LinusU

@LinusU What do you think when adding a state willShown like shown state to know when keyboardWillShow and keyboardWillHide

phuocantd avatar Nov 29 '21 09:11 phuocantd