discussions-and-proposals icon indicating copy to clipboard operation
discussions-and-proposals copied to clipboard

Protect calls to native modules by default with a broad exception handler

Open pke opened this issue 3 years ago • 0 comments

Introduction

There are many faulty (android) native modules out there, that often threaten the stability of the whole app just by not properly handling (runtime) exceptions.

If RN would, by default, wrap each call to native modules exported functions in an exception handler and reject a promise in case an exception happens, then the overall stability of RN apps could improve.

Details

I recently had to deal with an increasing app crash rate in the Google play console. They all happened in one native module and all of them where unchecked runtime exceptions.

I could manually handle the exceptions and create patch for the module using patch-package. And then I wondered why isn't RN pro-actively protecting its calls into 3rd party modules from the JS side using an exception handler.

try {
  callNativeModuleFunction()
} catch (RuntimeException) {
  reject(...)
}

Discussion points

  1. Speed

Maybe wrapping every call into an exception handler has speed impacts?

pke avatar Feb 10 '22 00:02 pke