directory icon indicating copy to clipboard operation
directory copied to clipboard

Add topics and make searching by topics simpler

Open FarazPatankar opened this issue 5 years ago • 8 comments

I have displayed the topics associated with each library and also made them clickable. This way, whenever a user clicks a topic, they can search by that specific topic.

I also created a small demo to see the feature in action. add-topics

FarazPatankar avatar May 09 '20 16:05 FarazPatankar

hello! thanks for the pr! after seeing this in the ui i'm not totally sure we want it to be featured so prominently. i'll defer to @jonsamp for design ideas here.

also, i noticed that we're already factoring in topics when you search, so that's nice! the ui is the only remaining bit

brentvatne avatar May 09 '20 21:05 brentvatne

Haha, fair enough. I thought the page could use some colors but I am open to changing whatever.

I was also considering using icons for the platforms but I didn't know what to use for MacOS. 🤔

FarazPatankar avatar May 09 '20 21:05 FarazPatankar

Another thing to consider for these tags - currently we're just using "topics" from GitHub, but this doesn't work too well in some situations, eg: if a library is inside of a monorepo, it can't have its own topics. So we should maybe use npm keywords in addition to GitHub topics and uniq them.

brentvatne avatar May 10 '20 01:05 brentvatne

I'd be open to that. Are we already fetching that information?

FarazPatankar avatar May 10 '20 02:05 FarazPatankar

not yet - we're just fetching download stats from npm: https://github.com/react-native-community/directory/blob/master/scripts/fetch-npm-data.js

brentvatne avatar May 13 '20 04:05 brentvatne

This is a cool feature! Thanks for adding it. Since there are many topics and they act like site links, I think we can style these like links. Here's a design that puts topics below the description. The text-size here is 12px (and the background and border is the same as the link styling):

Screen Shot 2020-05-15 at 10 42 05 AM Screen Shot 2020-05-15 at 10 44 34 AM

jonsamp avatar May 15 '20 14:05 jonsamp

Ooh, I like that. I'll try to update and push this over the weekend!

FarazPatankar avatar May 15 '20 15:05 FarazPatankar

lovely @jonsamp!

brentvatne avatar May 15 '20 22:05 brentvatne