error-message icon indicating copy to clipboard operation
error-message copied to clipboard

`as` prop does not take precedence over components

Open IanVS opened this issue 4 years ago • 2 comments

As seen in https://github.com/react-hook-form/error-message/pull/87#discussion_r714144172, as does not take precedence over render if the value provided to it is a component rather than an element.

The snapshot generated in https://github.com/react-hook-form/error-message/pull/87 is not correct, and should be fixed.

IanVS avatar Dec 03 '21 21:12 IanVS

Thank you very much @IanVS sorry for the delay response. Merged and released.

bluebill1049 avatar Nov 09 '22 00:11 bluebill1049

The PR mentioned above #87 does not fix this issue, it was spawned from that PR, but a new PR is needed. https://github.com/react-hook-form/error-message/pull/87/files/f0d5c51b3d04006eaa6bf19ed7224a312cbdb0f6#r762061758

I think this should be re-opened.

IanVS avatar Dec 07 '22 15:12 IanVS